This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Patch: FYI: natFile.cc cleanup
- From: Tom Tromey <tromey at redhat dot com>
- To: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 02 Feb 2002 01:05:30 -0700
- Subject: Patch: FYI: natFile.cc cleanup
- Reply-to: tromey at redhat dot com
I'm checking this in.
This removes some old, incorrect FIXME comments from natFile.cc.
FYI, natFile.cc has a global Java variable ("unixroot") that isn't
declared in File.java (a practice we've been talking about
deprecating). I didn't know about (or remember) this one. I'm not
certain we really need this; perhaps we could just return a new array
for each call.
Tom
Index: ChangeLog
from Tom Tromey <tromey@redhat.com>
* java/io/natFile.cc: Removed old "FIXME" comments.
Index: java/io/natFile.cc
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/io/natFile.cc,v
retrieving revision 1.13
diff -u -r1.13 natFile.cc
--- java/io/natFile.cc 2001/07/18 18:35:12 1.13
+++ java/io/natFile.cc 2002/02/02 07:43:48
@@ -1,6 +1,6 @@
// natFile.cc - Native part of File class for POSIX.
-/* Copyright (C) 1998, 1999, 2000, 2001 Free Software Foundation
+/* Copyright (C) 1998, 1999, 2000, 2001, 2002 Free Software Foundation
This file is part of libgcj.
@@ -41,7 +41,6 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
JvAssert (query == READ || query == WRITE || query == EXISTS);
#ifdef HAVE_ACCESS
@@ -63,7 +62,6 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
if (query == ISHIDDEN)
@@ -87,7 +85,6 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
#ifdef HAVE_STAT
@@ -109,7 +106,6 @@
{
char buf[MAXPATHLEN], buf2[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
#ifdef HAVE_REALPATH
@@ -138,7 +134,6 @@
#ifdef HAVE_DIRENT_H
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
DIR *dir = opendir (buf);
@@ -193,7 +188,6 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
#ifdef HAVE_MKDIR
@@ -208,7 +202,6 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
#if defined (HAVE_STAT) && defined (HAVE_CHMOD)
@@ -244,11 +237,9 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
char buf2[MAXPATHLEN];
total = JvGetStringUTFRegion (dest->path, 0, dest->path->length(), buf2);
- // FIXME?
buf2[total] = '\0';
#ifdef HAVE_RENAME
@@ -266,7 +257,6 @@
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
tb.actime = time / 1000;
@@ -282,7 +272,6 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
int fd = ::open (buf, O_CREAT | O_EXCL, 0644);
@@ -305,7 +294,6 @@
{
char buf[MAXPATHLEN];
jsize total = JvGetStringUTFRegion (path, 0, path->length(), buf);
- // FIXME?
buf[total] = '\0';
#ifdef HAVE_UNLINK