This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: FYI: More AWT merging
- From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- To: tromey at redhat dot com
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Fri, 18 Jan 2002 14:55:06 +1300
- Subject: Re: Patch: FYI: More AWT merging
- References: <87r8ooa2py.fsf@creche.redhat.com>
Tom Tromey wrote:
>I'm checking this in, another in the endless AWT merge.
>
>This merges MenuComponent, MenuItem, and Button.
>
>
>+/**
>+ * Returns a debugging string for this button.
>+ *
>+ * @return A debugging string for this button.
>+ */
>+protected String
>+paramString()
>+{
>+ return(getClass().getName() + "(label=" + getLabel() + ",actionCommand=" +
>+ getActionCommand() + ")");
>+}
>+
>+} // class Button
>+
>
The merged paramString methods may be wrong here - I dont think they
should ever call getClass().getName() or toString(). toString() calls
paramString (see Component).
getTreeLock() shouldn't be public.
regards
Bryce.