Re: Makefile patch: CNI header dependencies

[Jeff Sturm <jsturm at one-point dot com>]

(I'm still catching up after spending a week away in Canada with no
broadband access...)

On Fri, 23 Nov 2001, Bryce McKinlay wrote:
> Jeff, it looks like you may have introduced this problem with this patch:
>     ($(nat_headers),$(x_nat_headers)): Depend on libgcj.jar.
> 
> Why make the nat_headers depend on libgcj.jar?

Originally nat_headers relied only on this rule, I think:

## This is an evil hack to work around an automake limitation.  We
## need to ensure that the built headers are built before we try to
## compile the C++ sources, but we can't make the .o files depend on
## the headers, because in that case we'll force a complete rebuild of
## the C++ code whenever any .java file is touched.
all-recursive: $(nat_headers) $(x_nat_headers)

IIRC this worked OK as long as make was called recursively, but I had
trouble getting nat_headers to rebuild reliably, so I added the
dependency on libgcj.jar.

Note that the comment above seems at odds with the behavior you reported.

> Does this patch look okay to you guys?

It sure looks like an improvement.  At that time I was more concerned with
correctness than build times.

I don't know how portable that usage is, but we're constrained to GNU make
anyway.

> And BTW does anyone know why libtool is now doing the following during
> make install? its very annoying!

Good question.  Libtool is supposed to relink only on a few platforms
where it is required.  Is this happening on the trunk only?

Jeff