This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch: embedded target fixes

Tom wrote:
> What are the symptoms of this problem?
> If argv==NULL, couldn't we just test for that at runtime and avoid
> a configure option:

argv != NULL.  Garbage is passed in, which is often non-zero (or is that
"nonzero"? :-)
I only noticed this because argc could be quite large, causing out of memory
exceptions in JvConvertArgv's call to JvNewObjectArray.

> I think a ChangeLog entry is missing for the natSystem.cc change.
> Will this patch really work?  It looks to me like we use tzinfo[1]
> unconditionally as an argument to strcmp.  I think this will fail
> since in the patch this is NULL.

Ah, right.  I didn't try getSystemTimeZone.  I was just happy it compiled :-)
Will fix and follow-up with a new patch.

AG
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]