This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Patch: FYI: RMIC compilation


I'm checking this in.  It already went into Classpath.  This adds some
code so that the Classpath/libgcj rmic can run the compiler.  So far
it only works with gcj; other compilers can be added easily.

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* Makefile.in: Rebuilt.
	* Makefile.am (rmi_java_source_files): Added new files.
	* gnu/java/rmi/rmic/RMIC.java (compile): Uncommented; fixed to use
	new Compiler class.
	* gnu/java/rmi/rmic/Makefile.am (EXTRA_DIST): Updated.
	* gnu/java/rmi/rmic/Compile_gcj.java: New file.
	* gnu/java/rmi/rmic/CompilerProcess.java: New file.
	* gnu/java/rmi/rmic/Compiler.java: New file.

Index: Makefile.am
===================================================================
RCS file: /cvs/gcc/gcc/libjava/Makefile.am,v
retrieving revision 1.175
diff -u -r1.175 Makefile.am
--- Makefile.am 2001/10/10 22:25:42 1.175
+++ Makefile.am 2001/10/12 22:02:17
@@ -883,6 +883,9 @@
 gnu/java/rmi/registry/RegistryImpl.java	\
 gnu/java/rmi/registry/RegistryImpl_Skel.java \
 gnu/java/rmi/registry/RegistryImpl_Stub.java \
+gnu/java/rmi/rmic/Compile_gcj.java \
+gnu/java/rmi/rmic/Compiler.java	\
+gnu/java/rmi/rmic/CompilerProcess.java \
 gnu/java/rmi/rmic/RMIC.java \
 gnu/java/rmi/rmic/TabbedWriter.java \
 gnu/java/rmi/server/ProtocolConstants.java \
Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libjava/Makefile.in,v
retrieving revision 1.186
diff -u -r1.186 Makefile.in
--- Makefile.in 2001/10/10 22:25:42 1.186
+++ Makefile.in 2001/10/12 22:02:20
@@ -632,6 +632,9 @@
 gnu/java/rmi/registry/RegistryImpl.java	\
 gnu/java/rmi/registry/RegistryImpl_Skel.java \
 gnu/java/rmi/registry/RegistryImpl_Stub.java \
+gnu/java/rmi/rmic/Compile_gcj.java \
+gnu/java/rmi/rmic/Compiler.java	\
+gnu/java/rmi/rmic/CompilerProcess.java \
 gnu/java/rmi/rmic/RMIC.java \
 gnu/java/rmi/rmic/TabbedWriter.java \
 gnu/java/rmi/server/ProtocolConstants.java \
@@ -1580,6 +1583,9 @@
 .deps/gnu/java/rmi/registry/RegistryImpl.P \
 .deps/gnu/java/rmi/registry/RegistryImpl_Skel.P \
 .deps/gnu/java/rmi/registry/RegistryImpl_Stub.P \
+.deps/gnu/java/rmi/rmic/Compile_gcj.P \
+.deps/gnu/java/rmi/rmic/Compiler.P \
+.deps/gnu/java/rmi/rmic/CompilerProcess.P \
 .deps/gnu/java/rmi/rmic/RMIC.P .deps/gnu/java/rmi/rmic/TabbedWriter.P \
 .deps/gnu/java/rmi/server/ProtocolConstants.P \
 .deps/gnu/java/rmi/server/RMIDefaultSocketFactory.P \
Index: gnu/java/rmi/rmic/Compile_gcj.java
===================================================================
RCS file: Compile_gcj.java
diff -N Compile_gcj.java
--- /dev/null	Tue May  5 13:32:27 1998
+++ gnu/java/rmi/rmic/Compile_gcj.java Fri Oct 12 15:02:20 2001
@@ -0,0 +1,50 @@
+/*
+  Copyright (c) 2001 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+As a special exception, if you link this library with other files to
+produce an executable, this library does not by itself cause the
+resulting executable to be covered by the GNU General Public License.
+This exception does not however invalidate any other reasons why the
+executable file might be covered by the GNU General Public License.
+ */
+
+package gnu.java.rmi.rmic;
+
+/** Subclass of Compiler that can be used to invoke gcj.  */
+public class Compile_gcj extends CompilerProcess
+{
+  public String[] computeArguments (String filename)
+  {
+    int len = 3 + (dest == null ? 0 : 2);
+    String[] result = new String[len];
+    int i = 0;
+
+    result[i++] = "gcj";
+    result[i++] = "-C";
+    if (dest != null)
+      {
+	result[i++] = "-d";
+	result[i++] = dest;
+      }
+    result[i++] = filename;
+
+    return result;
+  }
+}
Index: gnu/java/rmi/rmic/Compiler.java
===================================================================
RCS file: Compiler.java
diff -N Compiler.java
--- /dev/null	Tue May  5 13:32:27 1998
+++ gnu/java/rmi/rmic/Compiler.java Fri Oct 12 15:02:20 2001
@@ -0,0 +1,75 @@
+/*
+  Copyright (c) 2001 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+As a special exception, if you link this library with other files to
+produce an executable, this library does not by itself cause the
+resulting executable to be covered by the GNU General Public License.
+This exception does not however invalidate any other reasons why the
+executable file might be covered by the GNU General Public License.
+ */
+
+package gnu.java.rmi.rmic;
+
+/** A Compiler object can be used to compile a .java file into a
+ * .class file.  This is an abstract class; the
+ * <code>getInstance()</code> method is used to obtain the actual
+ * compiler object.  */
+public abstract class Compiler
+{
+  // Can't directly instantiate.
+  protected Compiler ()
+  {
+  }
+
+  /** Create a new compiler instance.  */
+  public static Compiler getInstance ()
+  {
+    return getInstance (System.getProperty ("classpath.compiler", "gcj"));
+  }
+
+  /** Create a new compiler instance given the name of the compiler.  */
+  public static Compiler getInstance (String name)
+  {
+    try
+      {
+	Class k = Class.forName (classPrefix + name);
+	return (Compiler) k.newInstance ();
+      }
+    catch (Throwable _)
+      {
+      }
+    return null;
+  }
+
+  /** Set the directory where output files will be put.  */
+  public void setDestination (String dest)
+  {
+    this.dest = dest;
+  }
+
+  /** Compile the given file.  Throws exception on error.  */
+  public abstract void compile (String name) throws Exception;
+
+  /** The destination directory, or null if none set.  */
+  protected String dest;
+
+  /** Class prefix used when trying to find instance.  */
+  private static final String classPrefix = "gnu.java.rmi.rmic.Compile_";
+}
Index: gnu/java/rmi/rmic/CompilerProcess.java
===================================================================
RCS file: CompilerProcess.java
diff -N CompilerProcess.java
--- /dev/null	Tue May  5 13:32:27 1998
+++ gnu/java/rmi/rmic/CompilerProcess.java Fri Oct 12 15:02:20 2001
@@ -0,0 +1,61 @@
+/*
+  Copyright (c) 2001 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+As a special exception, if you link this library with other files to
+produce an executable, this library does not by itself cause the
+resulting executable to be covered by the GNU General Public License.
+This exception does not however invalidate any other reasons why the
+executable file might be covered by the GNU General Public License.
+ */
+
+package gnu.java.rmi.rmic;
+
+/** Subclass of Compiler that can be subclassed to invoke a process to
+ * do its work.  */
+public abstract class CompilerProcess extends Compiler
+{
+  /** This is used to compute the command line for the process.  */
+  public abstract String[] computeArguments (String filename);
+
+  public void compile (String name) throws Exception
+  {
+    String[] args = computeArguments (name);
+    Process p = Runtime.getRuntime ().exec (args);
+    // FIXME: probably should collect compiler output here and then
+    // put it into the exception message.
+    int result;
+    while (true)
+      {
+	try
+	  {
+	    result = p.waitFor ();
+	    break;
+	  }
+	catch (InterruptedException _)
+	  {
+	  }
+      }
+    if (result != 0)
+      {
+	// FIXME: wrong exception class.
+	throw new Exception ("compiler exited with status: " + result);
+      }
+  }
+}
Index: gnu/java/rmi/rmic/RMIC.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/rmi/rmic/RMIC.java,v
retrieving revision 1.1
diff -u -r1.1 RMIC.java
--- gnu/java/rmi/rmic/RMIC.java 2001/08/28 00:03:24 1.1
+++ gnu/java/rmi/rmic/RMIC.java 2001/10/12 22:02:21
@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 1996, 1997, 1998, 1999 Free Software Foundation, Inc.
+  Copyright (c) 1996, 1997, 1998, 1999, 2001 Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
 
@@ -38,7 +38,6 @@
 import java.util.Arrays;
 import java.lang.Comparable;
 import gnu.java.rmi.server.RMIHashes;
-// import kaffe.tools.compiler.Compiler;
 
 public class RMIC {
 
@@ -839,16 +838,12 @@
 }
 
 private void compile(String name) throws Exception {
-	throw new Error ("Not implemented");
-//  	Compiler comp = Compiler.getInstance();
-//  	if (verbose) {
-//  		System.out.println("[Compiling class " + name + "]");
-//  	}
-//  	comp.setDestination(destination);
-//  	boolean result = comp.compile(name);
-//  	if (result == false) {
-//  		throw comp.getException();
-//  	}
+	Compiler comp = Compiler.getInstance();
+	if (verbose) {
+		System.out.println("[Compiling class " + name + "]");
+	}
+	comp.setDestination(destination);
+	comp.compile(name);
 }
 
 private static String getPrettyName(Class cls) {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]