This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: jcf-write and last_bc
- To: tromey at redhat dot com
- Subject: Re: Patch: jcf-write and last_bc
- From: Per Bothner <per at bothner dot com>
- Date: Mon, 08 Oct 2001 16:51:49 -0700
- CC: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Java Patch List <java-patches at gcc dot gnu dot org>, Alexandre Petit-Bianco <apbianco at cygnus dot com>
- References: <87bsjh1znm.fsf@creche.redhat.com>
Tom Tromey wrote:
>While looking at some other problems with bytecode generation, I
>noticed that `state->last_bc' isn't always updated correctly. OP1
>sets this, and OP1 is also used to emit data. When this happens,
>last_bc will be set to some arbitrary byte value.
>
>In this patch I've introduced OP1DATA, which doesn't set last_bc and
>which is used whenever we're output data (as opposed to an opcode).
>
I can't say I like this patch, but it is hard for me to be specific without
understanding whatever problem the last_bc field is supposed to fix.
Alex added it 2000-10-18 and says it fixes "gcj/232", but I don't know
how to find that in the merged database. On general principles, I dislike
adding a nop.