This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Merging BufferedInputStream with Classpath
- To: Mark Wielaard <mark at klomp dot org>
- Subject: Re: Merging BufferedInputStream with Classpath
- From: Tom Tromey <tromey at redhat dot com>
- Date: 07 Oct 2001 18:01:37 -0600
- Cc: java-patches at gcc dot gnu dot org
- References: <20011007003943.A4110@klomp.org> <20011007125705.A32429@klomp.org>
- Reply-To: tromey at redhat dot com
>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
Mark> Note that the patch I posted made refill() a private method.
Mark> This is incorrect since InputStreamReader accesses refill() directly.
Mark> The InputStreamReader.refill() comments actually say:
Mark> // We have knowledge of the internals of BufferedInputStream
Mark> // here. Eww.
Thanks -- with this change it is fine to go in.
Note that the use of refill in InputStreamReader is still a bit wrong.
I think there are still cases where InputStreamReader can fail to make
progress. This code needs some attention and reworking.
Tom