This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PR 3426 fix


Quoth Tom Tromey on , 17 July:
: 
: I went and read the libc docs on iconv.  Now I think the right code
: should look like this:
: 
:       if (errno == EINVAL || errno == E2BIG)
: 	return 0;

It's not true that 0 chars were converted on E2BIG.  It is true that
old_outlength - outlength / sizeof(jchar) (or whatever those vars were
called) chars were converted on E2BIG.  

: Hmm... a comment later on says that glibc 2.1.3 doesn't correctly set 
: errno.  Not sure what to do about that.  
: 
: What do you think?  

Is there an imperative to accomodate the bugs of old versions of
glibc?  I don't care about it myself.  I do think that having this
case working correctly with one version is better than having it
working correctly with none.  I am personally content as long as the
working version is mine, i.e. current.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]