This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: SHA1PRNG fix
- To: green at cygnus dot com
- Subject: Re: Patch: SHA1PRNG fix
- From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- Date: Tue, 17 Jul 2001 14:12:50 +1200
- CC: java-patches at gcc dot gnu dot org, classpath at gnu dot org
- References: <200107110303.UAA18775@fencer.cygnus.com>
Anthony Green wrote:
> I believe that these two array copies have source and destination
> operands mixed up. This random number generator produces a never
> ending streamn of zeros otherwise.
>
> Ok to commit?
Yes, this looks fine to me.
> The Random constructor calls setSeed() at a time when SecureRandom has
> not yet initilialized secureRandomSpi, resulting in a
> NullPointerException. This tweak fixes..
>
> EncodedKeySpec is supposed to impement KeySpec.
>
> Ok to commit?
Likewise for these.
In the absence of any active maintainers for the java.security
implementation stepping up, you should probibly feel free to check in such
fixes without approval.
regards,
Bryce.