This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: patches for DeflaterOutputStream.java and ZipOutputStream.java
- To: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- Subject: Re: patches for DeflaterOutputStream.java and ZipOutputStream.java
- From: Per Bothner <per at bothner dot com>
- Date: 02 Apr 2001 09:26:43 -0700
- Cc: java-patches at gcc dot gnu dot org
- References: <m2n1a3m7d2.fsf@kelso.bothner.com><3AC7CA0D.82639906@waitaki.otago.ac.nz>
Bryce McKinlay <bryce@waitaki.otago.ac.nz> writes:
> There is an undocumented zlib flag (called NO_HEADER in Java) which is used to
> turn the zlib header off when reading and writing from zip files. You should
> check that this is being set correctly? I remember this being a problem in the
> ZipInputStream originally too.
I did look at that. I'm fairly sure I was turning it off, but I may
have gotten confused.
> Yeah, except that [by-passing zlib for STORED] probably hides bugs
> that only occur when using compressed mode!
Quite possibly - but testing compressed archives (and jar files) needs
to be done separately anyway. (I probably won't get to that at least
not for a while.)
> Anything that improves the ZipOutput situation for you is probably a good
> thing.
Yes - I figured that code was so broken any changes I made would be
an improvement, so I' checked it in.
--
--Per Bothner
per@bothner.com http://www.bothner.com/~per/