This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: java.io PipedInputStream PipedOutputStream PipedReader PipedWriter
- To: Bryce McKinlay <bryce at albatross dot co dot nz>
- Subject: Re: java.io PipedInputStream PipedOutputStream PipedReader PipedWriter
- From: Tom Tromey <tromey at redhat dot com>
- Date: 05 Jan 2001 10:36:17 -0700
- Cc: java-patches at sources dot redhat dot com
- References: <3A55845C.5C34D8E5@albatross.co.nz>
- Reply-To: tromey at redhat dot com
>>>>> "Bryce" == Bryce McKinlay <bryce@albatross.co.nz> writes:
Bryce> The Piped I/O classes we inherited from classpath were somewhat
Bryce> broken (especially PipedReader/PipedWriter). These new
Bryce> implementations are much simpler and hopefully less buggy -
Bryce> they work for my code and pass all the test cases I found (JCL,
Bryce> Kaffe, Classpath).
There are some Mauve tests too.
BTW I noticed in the Reader classes you replaced synchronized(lock)
with synchronization on the pipe itself. This seems wrong. I thought
Readers were always supposed to synchronize on their lock object.
It might only matter if the user tries to subclass PipedReader.
Tom