This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: Patch: RoundRectangle2D
- To: Bryce McKinlay <bryce at albatross dot co dot nz>
- Subject: Re: Patch: RoundRectangle2D
- From: Tom Tromey <tromey at redhat dot com>
- Date: 03 Dec 2000 18:18:28 -0700
- Cc: Java Patch List <java-patches at sourceware dot cygnus dot com>
- References: <871yvpdwd5.fsf@creche.redhat.com> <3A2ADBE5.5368C1A5@albatross.co.nz>
- Reply-To: tromey at redhat dot com
Bryce> Cool, good to see some progress on the AWT stuff. I've been
Bryce> wanting to get back to work on the gtk peers for a while, but I
Bryce> want to finish off the collections work first...
Have you seen a recent collections regression? I can't compile
TreeMap right now -- but I could last week.
Bryce> There is an argument that using the accessors is more correct
Bryce> in case somebody overrides them, but if override setX(), for
Bryce> example, then you really need to call super.setX() as well in
Bryce> order to do anything useful.
Thia makes sense to me. Thanks. I agree that we should just use the
fields directly. In some cases, though, this will mean moving methods
into subclasses (eg Rectangle2D doesn't have any fields -- they are
always in subclasses).
The geom.*2D stuff bugs me. It is a poor excuse for parameterized
types. Doing it by hand means extra maintenance burden for us.
Bleah.
Tom