This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: Various gij/jar/zip patches
- To: Anthony Green <green at cygnus dot com>
- Subject: Re: Various gij/jar/zip patches
- From: Mark Wielaard <mark at klomp dot org>
- Date: Sun, 20 Aug 2000 21:13:13 +0200
- Cc: java-patches at sources dot redhat dot com
- References: <200008201747.KAA05489@hoser.cygnus.com>
Hi,
On Sun, Aug 20, 2000 at 10:47:55AM -0700, Anthony Green wrote:
>
> Index: libjava/java/util/jar/JarFile.java
> ===================================================================
> RCS file: /cvs/java/libgcj/libjava/java/util/jar/JarFile.java,v
> retrieving revision 1.4
> diff -u -p -u -r1.4 JarFile.java
> --- JarFile.java 2000/08/19 18:19:42 1.4
> +++ JarFile.java 2000/08/20 17:38:56
> @@ -232,7 +232,7 @@ public class JarFile extends ZipFile {
> public ZipEntry getEntry(String name) {
> ZipEntry entry = super.getEntry(name);
> if (entry != null) {
> - JarEntry jarEntry = new JarEntry(getEntry(name));
> + JarEntry jarEntry = new JarEntry(super.getEntry(name));
> if (manifest != null) {
> jarEntry.attr = manifest.getAttributes(name);
> // XXX jarEntry.certs
Thanks for finding this. Note that you should actually do
JarEntry jarEntry = new JarEntry(entry);
because now you are just calling super.getEntry(name) twice.
Cheers,
Mark