This is the mail archive of the java-patches@sources.redhat.com mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: Patch: createZipEntry

To: Tom Tromey <tromey at cygnus dot com>
Subject: Re: Patch: createZipEntry
From: Mark Wielaard <mark at klomp dot org>
Date: Sun, 20 Aug 2000 16:36:59 +0200
Cc: Java Patch List <java-patches at sourceware dot cygnus dot com>
References: <877l9d10o5.fsf@creche.i-did-not-set--mail-host-address--so-shoot-me>

Hi,

On Sat, Aug 19, 2000 at 02:00:26PM -0600, Tom Tromey wrote:
> I read the docs for ZipInputStream.createZipEntry and I think this is
> a reasonable implementation.
>  [...]
> +    return new ZipEntry (name);

Yes, this is what it is supposed to do.
But you should also replace all occurances of new ZipEntry (name) with
createZipEntry (name) so JarInputStream has a change to add the Attribute
values to it. I have a documentation/1.2/1.3/bug fix patch for java.util.zip
that does this and that I will post as soon as I have proper net access.

Cheers,

Mark

References:
- Patch: createZipEntry
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]