This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: Patch: java.awt.image
- To: "Rolf W. Rasmussen" <rolfwr at ii dot uib dot no>
- Subject: Re: Patch: java.awt.image
- From: Tom Tromey <tromey at cygnus dot com>
- Date: Sun, 23 Jul 2000 12:53:59 -0700 (PDT)
- Cc: java-patches at sources dot redhat dot com
- References: <20000723212850.A7024@amy>
Rolf> Here is a patch (not committed) that merges in some of the work
Rolf> I've been doing on Java2D. How does it look? I'm a bit unsure
Rolf> whether the utility classes BitMaskExtent has been put in the
Rolf> right place.
It looks great.
Usually we put things in gnu.gcj depending on the package they augment
-- eg gnu.gcj.util is helper code for java.util. So I'd suggest
making gnu.gcj.awt and putting your code in there.
Also consider making helper classes "final" if that makes sense.
Thanks for doing this work!
Tom