This is the mail archive of the
java-patches@sourceware.cygnus.com
mailing list for the Java project.
RE: Patch: java.lang.ThreadGroup merge
- To: "Bryce McKinlay" <bryce at albatross dot co dot nz>, <java-patches at sourceware dot cygnus dot com>, <classpath at gnu dot org>
- Subject: RE: Patch: java.lang.ThreadGroup merge
- From: "John Keiser" <john at ieffects dot com>
- Date: Tue, 20 Jun 2000 11:13:58 -0600
Many thanks. :) I will test Japhar+Classpath with this patch (I hope to get
time for this sometime in the next three nights).
Note: you are probably already doing this, but it's a good idea to look at
the VM Integration Guide
(http://www.gnu.org/software/classpath/doc/vmintegration.html) when messing
around with core classes like this so you make sure not to break VMs (well,
to make sure not to break Japhar anyway :). While ThreadGroup is not in the
VM interface, there is a note about it in the guide. Just for future
reference; the stuff you did was good, from first glances.
--John
> -----Original Message-----
> From: bryce@havoc.albatross.co.nz [mailto:bryce@havoc.albatross.co.nz]On
> Behalf Of Bryce McKinlay
> Sent: Tuesday, June 20, 2000 7:27 AM
> To: java-patches@sourceware.cygnus.com; classpath@gnu.org
> Subject: Patch: java.lang.ThreadGroup merge
>
>
> I merged the ThreadGroup classes from libgcj and classpath. The result
> should be cleaner and have less bugs then either of its ancestors
> (I noticed various different bugs in both versions while working on it).
> It should also now be JDK 1.2 complient.
>
> There are also some small associated libgcj changes required, the patch
> for which is below (ThreadGroup initializes its own static "root"
> ThreadGroup, so we no longer need to do this seperatly in _Jv_RunMain).
>
> I intend to check this in to both classpath and libgcj.
>
> regards
>
> [ bryce ]
>
>