This is the mail archive of the java-patches@sourceware.cygnus.com mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch: remove `final' hack in String.toString()


Bryce> Now that we have a fix for PR/2, we don't need this dumb hack
Bryce> in String.java. Checked in.

There are other places that we do something similar.
For instance, in BitSet.java:

      if (bs == null)
	throw new NullPointerException ();
      int max = Math.min(bits.length, bs.bits.length);

We never had a very well-defined policy for this stuff.
Right now I'm inclined to say that we should also explicitly throw a
NullPointerException when the value is not used,
e.g. java.io.File.File:

  public File (String p)
  {
    if (p == null)
      throw new NullPointerException ();
    path = p;
  }

Comments?
The idea here is that on native platforms we can rely on what we have
now.  On platforms without an MMU we'll have to modify the compiler to
do explicit checks everywhere.

Tom

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]