This is the mail archive of the java-patches@sourceware.cygnus.com mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [patch] fix for PR java.io/50

To: Bryce McKinlay <bryce at albatross dot co dot nz>
Subject: Re: [patch] fix for PR java.io/50
From: Tom Tromey <tromey at cygnus dot com>
Date: Sun, 31 Oct 1999 16:29:24 -0800 (PST)
Cc: Tom Tromey <tromey at cygnus dot com>, java-patches at sourceware dot cygnus dot com
References: <19991029160000.17469.qmail@sourceware.cygnus.com><381BFF91.2A2AB7F1@albatross.co.nz><199910311542.HAA00933@ferrule.cygnus.com><381CD97E.21D39CDE@albatross.co.nz>

>>>>> "Bryce" == Bryce McKinlay <bryce@albatross.co.nz> writes:

Bryce> Here's rev.2 of that patch:

Bryce> +    /* dont need to call super(in) here as long as the lock gets set */

My only comment is a nit: This should be a full sentence, with
puncuation ("Don't") and a period.  cf the GNU standards.
Fix this and just check it in -- I don't think you need to send a
revised patch to the list.

Thanks!
Tom

References:
- [patch] fix for PR java.io/50
  - From: Bryce McKinlay
- Re: [patch] fix for PR java.io/50
  - From: Tom Tromey
- Re: [patch] fix for PR java.io/50
  - From: Bryce McKinlay

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]