Re: java.text patches

[Tom Tromey <tromey at cygnus dot com>]

Bryce> Here's three micellanious patches for the java.text format
Bryce> classes.

I never replied to this -- oops.

Bryce> 1) a tenative fix for libgcj/38 - this fixes the circular
Bryce> initializer dependency by delaying the construction
Bryce> nonLocalizedSymbols until it is actually needed.

I still don't understand this bug.  Why does this circular dependency
matter?  Shouldn't class initialization work in the presence of
circular dependencies?  That is my recollection of the intent of the
code in Class::initializeClass (look for the "step 3" part, which
returns if the class initialization is "in progress").

Bryce> 2) The (String pattern) constructor for MessageFormat just
Bryce> calls applyPattern, which assumes that a locale has been
Bryce> set. It needs to set the default locale before calling
Bryce> applyPattern, or a NullPointerException occurs.

Bryce> 3) NumberFormat throws a ClassCastException if the object being
Bryce> formatted is not actually a Number. It should throw an
Bryce> IllegialArgumentException. Verfified against JDK behaviour.

Please check these two in.

Tom