Re: Patch: pthread fix

[Bryce McKinlay <bryce@albatross.co.nz>]

Tom, I get the following error compiling w/ the posix-thread.h changes:

c++ -DHAVE_CONFIG_H -I. -I../../../libjava -I./include -Iinclude
-I../../../libjava/include -I../../../libjava/../boehm-gc -I./../boehm-gc
-DLINUX_THREADS=1 -D_REENTRANT=1 -DSILENT=1 -DNO_SIGNALS=1 -DNO_DEBUGGING=1
-DJAVA_FINALIZATION=1 -I../../../libjava/../compat-include
-I../../../libjava/../zlib -I../../../libjava/../libffi/include
-I../libffi/include -fno-rtti -fvtable-thunks -ffloat-store -W -Wall -g -O2
-fvtable-thunks -D_GNU_SOURCE -Wp,-MD,.deps/prims.pp -c  -fPIC -DPIC
../../../libjava/prims.cc -o .libs/prims.lo
In file included from ../../../libjava/java/lang/Object.h:18,
                 from ../../../libjava/include/cni.h:16,
                 from ../../../libjava/prims.cc:20:
include/java-threads.h: In function `int _Jv_PthreadCheckMonitor(_Jv_Mutex_t
*)':
include/java-threads.h:115: `struct pthread_mutex_t' has no member named
`m_count'

This is on Redhat 6.0 (glibc 2.1)

regards

  [ bryce ]


Tom Tromey wrote:

> I'm committing the appended patch.  It fixes my previous pthread patch
> to do correct error checking.
>
> 1999-09-01  Tom Tromey  <tromey@cygnus.com>
>
>         * posix-threads.cc (_Jv_CondWait): Use _Jv_PthreadGetMutex.
>         * include/posix-threads.h (_Jv_Mutex_t): Define as structure,
>         except on Linux.
>         (_Jv_PthreadGetMutex): New function.
>         (_Jv_PthreadCheckMonitor): Use it.
>         (_Jv_MutexInit): Likewise.  ALso, initialize `count'.
>         (_Jv_MutexLock): Update `count'.
>         (_Jv_MutexUnlock): Likewise.
>         (_Jv_PthreadCheckMonitor): Use Linux-specific knowledge when
>         appropriate.