Re: patch: gcc 2.96 compile fixes, file creation mode, ServerSocket bind cleanup

[Bryce McKinlay <bryce@albatross.co.nz>]

Tom Tromey wrote:

> Bryce> I'll commit this tommorrow if there are no objections.
>
> It would be easier if the patch were actually a few smaller chunks:
> cast cleanups, the mode fix, and the net fixes.

I know, Its just that I'm too lazy to seperate them out since the cast and net
patches applied to the same source file ;-) I will see what I can do for the
commit.

> Actually, I find this change a bit distressing.  Is this due to a C++
> compiler change?  I think for seamless C++/Java integration to really
> be seamless, C++ boolean constants and Java boolean constants should
> be identical.  That is, I think we shouldn't need a cast here.

Yeah, I found that to be pretty odd too. Perhaps it isn't a problem in most cases,
but here the compiler seems to think that "false" is ambiguous (because the
java.lang.Boolean constructor is overloaded). Maybe its a compiler bug - shouldn't
it be implicitly interpreting "false" as a jboolean, given the choice?

> So for this little piece (the boolean cast) I'd rather get more
> information before checking it in.

ok.

  [ bryce ]