This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Test GCC conversion with reposurgeon available


On Tue, Dec 24, 2019 at 11:50:30AM +0000, Joseph Myers wrote:
> On Mon, 23 Dec 2019, Roman Zhuykov wrote:
> > I've never used zhroma@gcc.gnu.org email in ChangeLog files. So, it seems odd
> > that it is used in r270511 (my first commit as maintainer), but not in next
> 
> That's because that commit also edits ChangeLog entries from other 
> authors.  When a commit adds / edits ChangeLog entries for more than one 
> author (the difference between purely editing an existing entry and adding 
> a new one, possibly under an existing date/author header, for a 
> multi-author commit, is not something that can reliably be determined 
> automatically), the conversion falls back to using the committer identity 
> instead of picking one of the multiple relevant authors from the ChangeLog 
> files.

There is only one relevant author in r270511.  It edits a few wrong path
names in the previous changelog entries.  People often do similar things
(like fixing the commit date :-) )

Either never use <account>@gcc.gnu.org, or always use it, don't do the
worst of both worlds?


Maxim's conversion has this just fine: (from gcc-reparent):

commit 6d4633c4d15a92b88332c1e0cbc7f5c1c93c1a8a
Author:     Roman Zhuykov <zhroma@ispras.ru>
AuthorDate: Tue Apr 23 12:53:43 2019 +0000
Commit:     Roman Zhuykov <zhroma@ispras.ru>
CommitDate: Tue Apr 23 12:53:43 2019 +0000

    modulo-sched: fix branch scheduling issue (PR84032)
    
        PR rtl-optimization/84032
        * modulo-sched.c (ps_insn_find_column): Change condition so that
        branch will always be the last insn in a row inside partial
        schedule.
    
    testsuite:
    
        PR rtl-optimization/84032
        * gcc.dg/pr84032.c: New test.
    
    
    git-svn-id: https://gcc.gnu.org/svn/gcc/trunk@270511 138bc75d-0d04-0410-961f

(It also gets different author and committer right, and changing email
addresses over time).


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]