This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Commit messages and the move to git


On 19/12/2019 15:44, Jonathan Wakely wrote:
These scraped "INVALID" as the component from the changelog, because
it said "libgfortran/24685":

revert: re PR libfortran/24685 (real(16) formatted input is broken for
huge values (gfortran.dg/default_format_2.f90) [checkme: INVALID SVN
r142840])
revert: re PR libfortran/24685 (real(16) formatted input is broken for
huge values (gfortran.dg/default_format_2.f90) [checkme: INVALID SVN
r142841])

Shouldn't that be handled by the "compalias" dict?

Why are these invalid? The changelogs look OK:
re PR c++/46134 (constexpr vs. defaulted ctor [checkme: INVALID SVN r166171])
re PR c/11586 (after call sigaction, system() return wrong status
[checkme: INVALID SVN r187542])
re PR target/86677 (popcount builtin detection is breaking some kernel
build [checkme: INVALID SVN r266039])


INVALID means the PR was closed as invalid, which seems an suspect closure state for a PR that has had a patch installed. In some cases the bug really was invalid and the commit is just some doc or other type cleanup, but it's often hard to be sure in the automated code, so it's flagged up for manual checking.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]