This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Commit messages and the move to git


On Thu, 5 Dec 2019 at 10:41, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>
> On Thu, 5 Dec 2019 at 10:36, Richard Earnshaw (lists)
> <Richard.Earnshaw@arm.com> wrote:
> >
> > On 05/12/2019 10:32, Jonathan Wakely wrote:
> > > On Thu, 5 Dec 2019 at 10:25, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> > >>
> > >> On Wed, 4 Dec 2019 at 23:52, Richard Earnshaw (lists) wrote:
> > >>> I've just pushed a new trial conversion:
> > >>>
> > >>> https://gitlab.com/rearnsha/gcc-trial2-20191130
> > >>>
> > >>> The main differences between this and the previous trial are:
> > >>> - The author attributions should now be fixed, please let me know if you
> > >>> see any anomalies in this respect.
> > >>> - the emptycommit-* tags/branches are now gone.
> > >>> - the 'tags' used for revert and backport now use more gittish style
> > >>> revert: and backport:
> > >>> - the log entries for c++ style functions containing :: are now handled
> > >>> correctly by my summary generation script.
> > >>>
> > >>> Other issues are still being worked on.
> > >>
> > >> There's a bogus libstdc++ directory at the top level. That hasn't been
> > >> present for nearly 20 years, so some commit that should have deleted
> > >> it seems to be missing or incorrect.
> > >
> > > It was removed by r39445 i.e. this commit in the current Git mirror:
> > >
> > > commit 1030d23bf251914e12fc8c9d521e334e1f445afc
> > > Author: mmitchel <mmitchel@138bc75d-0d04-0410-961f-82ee72b054a4>
> > > Date:   Mon Feb 5 01:38:47 2001 +0000
> > >
> > >              Remove V2 C++ library.
> > >              * configure.in: Remove --enable-libstdcxx_v3 support.
> > >
> > >              * Makefile.in (site.exp): Always set HAVE_LIBSTDCXX_V3.
> > >              * configure.in: Remove --enable-libstdcxx_v3 support.
> > >              * configure: Regenerated.
> > >
> > >
> > >      git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@39445
> > > 138bc75d-0d04-0410-961f-82ee72b054a4
> > >
> >
> > Ok, this is one to keep an eye on.  There are a number of anomalous
> > commmits at present, which Eric is working on with a new approach to
> > replaying the SVN data into reposurgeon.  Once that is done we're hoping
> > that this sort of problem will go away.  (of course, if it doesn't then
> > the chances are we won't be using reposurgeon for the conversion at all).
>
> OK. There are several other deletions missing, as I see these in your
> conversion which aren't on trunk (paths relative to the libstdc++-v3
> dir because that's all I'm checking):
>
> Only in ./config/abi/post: solaris2.8

Should have been removed by r185392 which is present as
ec7b5a78e90a4245792f8d9a9288e9f98f904f87

> Only in ./config/os: irix

Should have been removed by r185390 aka 9cf50112d877a9b35faa68889ab5ba4ee73291b2

> Only in ./config/os: osf

Should have been removed by r185240 aka ed3aca91ef9c7f81b7f7a66ae0b936fde69d8b63

> Only in ./include/ext/pb_ds/detail/cc_hash_table_map_: standard_policies.hpp
> Only in ./include/ext/pb_ds/detail/gp_hash_table_map_: standard_policies.hpp

Both removed by r194107 which is missing.

> Only in ./src/c++98: compatibility-parallel_list-2.cc
> Only in ./src/c++98: compatibility-parallel_list.cc

Both renamed by r191837 aka 6099a280b4fceb232da81feb92f95b3d889f29c9

> Only in ./testsuite/20_util: is_explicitly_convertible

Removed by r186617 which is missing.

> Only in ./testsuite/26_numerics: cmath

Renamed by r186445 aka 99686a77aa36b93313ae29e4fffd2ae3ed7b549e

> Only in ./testsuite/28_regex/algorithms: 02_match

Removed by r188923 aka 7202cd20761d4dee77cdbcb677b0b667c83ddea2

> Only in ./testsuite/28_regex/basic_regex: regex.cc

Renamed by r192146 aka b70e38df276382a62d4dc13adf0751f435cc990b


> > This repo conversion is really for checking that the summaries I'm
> > generating are not just garbled, and the authors problem from the
> > previous trial are now fixed.
>
> OK, apart from the artefacts caused by me not knowing my own email
> address (discussed off-list), those look good to me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]