This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Commit messages and the move to git

On 19/11/2019 23:44, Joseph Myers wrote:
> On Tue, 19 Nov 2019, Segher Boessenkool wrote:
>> Most of the time after I type "git log" I type "/\<123456\>".  We need
>> to keep a way to easily map SVN revision ids to git commits, and
>> something a bit more elegant than the ugly git-svn footers would be nice.
> Whatever reposurgeon's "write --legacy" yield seems appropriate for making 
> the SVN revision ids readily available in the commit messages.  I don't 
> think the summary line is a good place for that information.
> I do think "Related to PR NNNNN (description)" or similar is a good 
> summary line to insert where the present summary line is just a ChangeLog 
> date/author line.

If we go that route, then there's a bit of auditing to do, because a
fair number of commits have simple typos in the pr numbers.  I can
produce a list of the most likely sources of error (there are about 550
from 40000 rewrites) that need looking at, but checking them all myself
would be very tedious.  Best would be to split the list up and divide
and conquer the checking across a few developers.

I think we'd just have to accept that manually checking all 40000
rewrites is impractical, so only those thrown up as suspicious can
really be checked this way (on checks I've made so far, only about 10%
of the highlighted cases are really wrong).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]