This is the mail archive of the
mailing list for the GCC project.
Re: Commit messages and the move to git
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: Jonathan Wakely <jwakely dot gcc at gmail dot com>, "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>, GCC Development <gcc at gcc dot gnu dot org>
- Date: Mon, 4 Nov 2019 17:42:47 +0000
- Subject: Re: Commit messages and the move to git
- Ironport-sdr: IMDFbqWvY19d23X8MZPkIc1/xoUpZADRld1EzbrCEUe3QDazjskzraOGJ2xjyLNaccO+fHM4IB qYSnVeEkp7+kbHdhF04TdHltjazy8lCegQk+cSNmeT4VKGgBn2UyfShHHzHkNDrPJR7+W8/LyE jc4tCr4JFZs9PLbkZumvsUGjy99aX7btaWdU7hJ5rEc08YA6Atbgh7HzbZC+MSH83OeIkEpm8D /bmKEGZVKnaszdeomlQn4YpxQfIg9Xf0O3EKiTnzU6LBnol3nZ8sl2TQp4APf02Yj0KLK/Avuj 3lI=
- Ironport-sdr: c05E72ysEPve8ULOKFpLnIBmxyGz8uLHdwy65cedCphU0PZ4SiPxIfS+Xn4iaGgggQaIFy74yT ZspOtEFOpMpw6tCrlL17N8YTuzsZss62rK9rg9D7gaSjePdgw/b3JFC3pNAYAyT5yRn6z5cg+5 eNUCD9JfA1yyivtxJkz2hcqulHJ6lbKkySZ4hGotVLIGChNGKOA1tHlAYAZ72fqBKrezNkGdgJ WqQeR9Z7KmLUfvnHCZrnwz8RA4fLZFr2qACELif9112vocElJK0Y9i933KGnDWGi9GZYoz9ujG EZM=
- References: <firstname.lastname@example.org> <CAH6eHdRpdjFwnwrM6EXN3nsz6nSvkyBpC4ZdxZqrt1f=TZsFuw@mail.gmail.com> <20191104173348.GB16031@gate.crashing.org>
On Mon, 4 Nov 2019, Segher Boessenkool wrote:
> On Mon, Nov 04, 2019 at 04:19:25PM +0000, Jonathan Wakely wrote:
> > I've already proposed a more specific format for libstdc++:
> > https://gcc.gnu.org/ml/libstdc++/2019-09/msg00122.html
> PR libstdc++/12345 takes up the first 19 chars of the short subject,
> adding no useful information (unless the reader knows all PRs by heart,
> you need to look it up to know what it is).
> I usually put (PR12345) at the end of the subject. The area is clear
> from the rest of the subject already.
Agreed. (Hint to patch submitters: if the subject line of your patch
submission is just "Fix PR12345" or similar, people are less likely to
review your patch because nothing about the subject tells anyone that the
patch is in their area and so something they should pay attention to.
Patch submissions need to have subjects that make clear very quickly what
the patch is about. This is also why I don't care for [PATCH] tags at the
start of subject lines - they take away space for saying what the patch is
about, and on gcc-patches we can expect things are patches, [PATCH]
doesn't add useful information.)
I've been using git-style commit messages in GCC for the past five years.
Joseph S. Myers