This is the mail archive of the
mailing list for the GCC project.
write w/o approval policy (Re: [PATCH] clarify comments for implicit_p flag for built-ins)
- From: Martin Sebor <msebor at gmail dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>, Jeff Law <law at redhat dot com>
- Cc: GCC Mailing List <gcc at gcc dot gnu dot org>
- Date: Wed, 28 Nov 2018 11:39:55 -0700
- Subject: write w/o approval policy (Re: [PATCH] clarify comments for implicit_p flag for built-ins)
- References: <email@example.com> <firstname.lastname@example.org> <email@example.com> <CAFiYyc18npaev42E=PJaF7Dj8vTngRaa57CM0+YrJrdaQY7nrQ@mail.gmail.com>
On 11/28/18 6:35 AM, Richard Biener wrote:
On Tue, Nov 27, 2018 at 3:52 AM Martin Sebor <firstname.lastname@example.org> wrote:
If there are no objections or suggestions for tweaks I'll commit
this updated comment this week.
Please do not commit such changes w/o approval.
Since you're the second maintainer to ask me that in response
to a patch to update comments I'd like to get some clarity here.
I have been assuming that the GCC Write access policy (quoted
below) lets those of us with write-after-approval make a judgment
call as to when a change is sufficiently safe to commit:
Obvious fixes can be committed without prior approval. Just
check in the fix and copy it to gcc-patches. A good test to
determine whether a fix is obvious: "will the person who
objects to my work the most be able to find a fault with my
fix?" If the fix is later found to be faulty, it can always
be rolled back. We don't want to get overly restrictive about
If we are not at liberty to make this judgment call in even
the most innocuous cases like comments, when does this policy
actually apply? (It should be updated to make it clear.)