This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Not quoted option names in errors and warnings
On 11/15/18 5:54 PM, Martin Sebor wrote:
> On 11/15/2018 03:12 AM, Martin Liška wrote:
>> Hi.
>>
>> I've done a quick grep of gcc/po/gcc.pot and I see quite a lot of missing quotations
>> of option names (~400). Is it something we should fix? How important is that?
>
> That's quite a few... I've been fixing these as I notice them,
> usually as part of related changes. The most onerous part of
> the cleanup is adjusting tests, especially under the target-
> specific ones. It's (obviously) not critical but I think it
> would be nice to make the quoting consistent throughout over
> time (if not in one go) and then put in place a -Wformat
> checker to detect the missing quoting as new diagnostics are
> introduced. Do you think it might be scriptable?
Hi.
Are you talking about a proper GCC warning that will be triggered once a warning
message is missing quotations?
I can definitely cook a patch in next stage1 and the testsuite fall out should
be easy to come with.
Martin
>
> Martin