This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: PROPOSAL: Extend inline asm syntax with size spec
- From: Joe Perches <joe at perches dot com>
- To: Peter Zijlstra <peterz at infradead dot org>
- Cc: Borislav Petkov <bp at alien8 dot de>, Segher Boessenkool <segher at kernel dot crashing dot org>, Ingo Molnar <mingo at kernel dot org>, Richard Biener <rguenther at suse dot de>, Michael Matz <matz at suse dot de>, gcc at gcc dot gnu dot org, Nadav Amit <namit at vmware dot com>, Ingo Molnar <mingo at redhat dot com>, linux-kernel at vger dot kernel dot org, x86 at kernel dot org, Masahiro Yamada <yamada dot masahiro at socionext dot com>, Sam Ravnborg <sam at ravnborg dot org>, Alok Kataria <akataria at vmware dot com>, Christopher Li <sparse at chrisli dot org>, Greg Kroah-Hartman <gregkh at linuxfoundation dot org>, "H. Peter Anvin" <hpa at zytor dot com>, Jan Beulich <JBeulich at suse dot com>, Josh Poimboeuf <jpoimboe at redhat dot com>, Juergen Gross <jgross at suse dot com>, Kate Stewart <kstewart at linuxfoundation dot org>, Kees Cook <keescook at chromium dot org>, linux-sparse at vger dot kernel dot org, Philippe Ombredanne <pombredanne at nexb dot com>, Thomas Gleixner <tglx at linutronix dot de>, virtualization at lists dot linux-foundation dot org, Linus Torvalds <torvalds at linux-foundation dot org>, Chris Zankel <chris at zankel dot net>, Max Filippov <jcmvbkbc at gmail dot com>, linux-xtensa at linux-xtensa dot org, Andrew Morton <akpm at linux-foundation dot org>
- Date: Thu, 01 Nov 2018 02:20:40 -0700
- Subject: Re: PROPOSAL: Extend inline asm syntax with size spec
- References: <20181009145330.GT29268@gate.crashing.org> <alpine.LSU.2.20.1810100909140.16707@zhemvz.fhfr.qr> <20181010072240.GB103159@gmail.com> <20181010080324.GV29268@gate.crashing.org> <20181010081906.GA5533@zn.tnic> <20181010185432.GB29268@gate.crashing.org> <20181010191427.GF5533@zn.tnic> <20181013193335.GD31650@zn.tnic> <20181031125526.GA13219@hirez.programming.kicks-ass.net> <5f987ecbb4962b4796615928d9d71f2cf9b21a3b.camel@perches.com> <20181101090114.GE3159@hirez.programming.kicks-ass.net>
On Thu, 2018-11-01 at 10:01 +0100, Peter Zijlstra wrote:
> On Wed, Oct 31, 2018 at 10:20:00PM -0700, Joe Perches wrote:
> > On Wed, 2018-10-31 at 13:55 +0100, Peter Zijlstra wrote:
> > > Anyway, with the below patch, I get:
> > >
> > > text data bss dec hex filename
> > > 17385183 5064780 1953892 24403855 1745f8f defconfig-build/vmlinux
> > > 17385678 5064780 1953892 24404350 174617e defconfig-build/vmlinux
> > >
> > > Which shows we inline more (look for asm_volatile for the actual
> > > changes).
> > []
> > > scripts/checkpatch.pl | 8 ++---
> > > scripts/genksyms/keywords.c | 4 +--
> > > scripts/kernel-doc | 4 +--
> >
> > I believe these should be excluded from the conversions.
>
> Probably, yes. It compiled, which was all I cared about :-)
>
> BTW, if we do that conversion, we should upgrade the checkpatch warn to
> an error I suppose.
More like remove altogether as __inline and __inline__
will no longer be #defined
$ git grep -P 'define\s+__inline'
include/linux/compiler_types.h:#define __inline__ inline
include/linux/compiler_types.h:#define __inline inline