This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Policy for reverting someone else commit?
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: sgk at troutmask dot apl dot washington dot edu,Steve Kargl <sgk at troutmask dot apl dot washington dot edu>,gcc at gcc dot gnu dot org
- Date: Sun, 20 May 2018 07:27:06 +0200
- Subject: Re: Policy for reverting someone else commit?
- References: <20180520052025.GA25869@troutmask.apl.washington.edu>
On May 20, 2018 7:20:25 AM GMT+02:00, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote:
>So, there is a P1 blocking bootstrap failure on trunk.
>I've opened a PR and finally had time to locate the
>offending commit.
>
>https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85843
>
>As I cannot bootstrap gcc, I cannot test a set of
>patches for gfortran that I have in my tree nor
>identify which recent commit introduced a regression
>in the gfortran testsuite.
>
>I've scanned gcc.gnu.org and wiki, but have not
>been able to find a stated policy of reverting a
>patch committed by someone.
>
>The offending commit was done on a Friday. I
>have no idea if the committer responsible for
>the bootstrap failure works on the weekend.
>
>So, can I revert the commit (and don't in my
>local repository)?
IIRC there is a 24h rule that global maintainers can invoke. Not sure if that is formally documented somewhere.
Usually it's much easier to revert this in your local repo for the time being.
Richard.