This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Write dependency information (-M*) even if there are errors
- From: Boris Kolpackov <boris at codesynthesis dot com>
- To: gcc at gcc dot gnu dot org
- Date: Sun, 6 Aug 2017 09:59:05 +0200
- Subject: [PATCH] Write dependency information (-M*) even if there are errors
- Authentication-results: sourceware.org; auth=none
Hi,
Currently GCC does not write extracted header dependency information
if there are errors. However, this can be useful when dealing with
outdated generated headers that trigger errors which would have been
resolved if we could update it. A concrete example in our case is a
version check with #error.
The included (trivial) patch changes this behavior. Note also that
this is how Clang already behaves. I've tested the patch in build2
and everything works well (i.e., no invalid dependency output in the
face of various preprocessor errors such as #error, stray #else, etc).
While I don't foresee any backwards-compatibility issues with such
an unconditional change (after all, the compiler still exists with
an error status), if there are concerns, I could re-do it via an
option (e.g., -ME, analogous to -MG).
P.S. I have the paperwork necessary to contribute on file with FSF.
Thanks,
Boris
Index: gcc/c-family/ChangeLog
===================================================================
--- gcc/c-family/ChangeLog (revision 250514)
+++ gcc/c-family/ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2017-08-06 Boris Kolpackov <boris@codesynthesis.com>
+
+ * c-opts.c (c_common_finish): Write dependency information even if
+ there are errors.
+
2017-07-14 David Malcolm <dmalcolm@redhat.com>
* c-common.c (try_to_locate_new_include_insertion_point): New
Index: gcc/c-family/c-opts.c
===================================================================
--- gcc/c-family/c-opts.c (revision 250514)
+++ gcc/c-family/c-opts.c (working copy)
@@ -1152,8 +1152,11 @@
{
FILE *deps_stream = NULL;
- /* Don't write the deps file if there are errors. */
- if (cpp_opts->deps.style != DEPS_NONE && !seen_error ())
+ /* Note that we write the dependencies even if there are errors. This is
+ useful for handling outdated generated headers that now trigger errors
+ (for example, with #error) that would be resolved by re-generating
+ them. In a sense this complements -MG. */
+ if (cpp_opts->deps.style != DEPS_NONE)
{
/* If -M or -MM was seen without -MF, default output to the
output stream. */