This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
How do we write unused arguments?
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: gcc at gcc dot gnu dot org
- Date: Thu, 5 Nov 2015 10:32:11 +0100
- Subject: How do we write unused arguments?
- Authentication-results: sourceware.org; auth=none
When reviewing patches I'm never quite sure which of the following we
should be using:
some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED)
some_target_hook (tree decl, machine_mode ARG_UNUSED (mode))
some_target_hook (tree decl, machine_mode /* mode */)
some_target_hook (tree decl, machine_mode)
Any opinions? I'm leaning towards the last version since it's idiomatic
in the language we're using and has the least amount of visual clutter.
If no one comments, I'll start enforcing that in patch reviews.
Currently no one seems sure and everything is getting totally inconsistent.
Bernd