This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Postpone expanding va_arg until pass_stdarg

From: Tom de Vries <Tom_deVries at mentor dot com>
To: Richard Biener <richard dot guenther at gmail dot com>
Cc: Michael Matz <matz at suse dot de>, Jakub Jelinek <jakub at redhat dot com>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
Date: Wed, 11 Feb 2015 19:19:38 +0100
Subject: Re: Postpone expanding va_arg until pass_stdarg
Authentication-results: sourceware.org; auth=none
References: <54CA6BB1 dot 10502 at mentor dot com> <20150129172535 dot GN1746 at tucnak dot redhat dot com> <54CAB232 dot 1090005 at mentor dot com> <CAFiYyc1XB_6-P32CroiFbE2Of3j3vORu5d7ALuEgoN8F9yk0Tg at mail dot gmail dot com> <54CB61C8 dot 4060801 at mentor dot com> <alpine dot LNX dot 2 dot 00 dot 1501301322400 dot 18611 at wotan dot suse dot de> <54CF8AB8 dot 5040405 at mentor dot com> <alpine dot LNX dot 2 dot 00 dot 1502021628300 dot 18611 at wotan dot suse dot de> <54D0979A dot 8030200 at mentor dot com> <alpine dot LNX dot 2 dot 00 dot 1502031434250 dot 18611 at wotan dot suse dot de> <54D9CDE9 dot 8010805 at mentor dot com> <CAFiYyc1oV+W4FNscZ61C_m7mYfPt+k5nuSECFnr9EGzoXy-bHQ at mail dot gmail dot com> <54DA05B1 dot 3070300 at mentor dot com> <CAFiYyc2EtSuM2ezbTau4kWfuU3muwATkR88JSDir-ZfiPBLdYw at mail dot gmail dot com>

On 10-02-15 14:46, Richard Biener wrote:

This patch is a way to achieve that gimplification doesn't call the actual
>gimplify_expr langhook, and it fixes the failure. But I'm guessing that's
>not the proper way to fix this.

More like

Index: gcc/tree.c
===================================================================
--- gcc/tree.c  (revision 220578)
+++ gcc/tree.c  (working copy)
@@ -5815,6 +5815,7 @@ free_lang_data (void)
       still be used indirectly via the get_alias_set langhook.  */
    lang_hooks.dwarf_name = lhd_dwarf_name;
    lang_hooks.decl_printable_name = gimple_decl_printable_name;
+  lang_hooks.gimplify_expr = lhd_gimplify_expr;
    /* We do not want the default decl_assembler_name implementation,
       rather if we have fixed everything we want a wrapper around it
       asserting that all non-local symbols already got their assembler

That worked, and allowed me to do a bootstrap on x86_64 for all languages andregtest for unix/ and unix/-m32 without any issues (other than scan-dump-treefailures for stdarg, since the va_list_gpr/fpr_size optimization is switched off).

That leaves just teaching the va_list_gpr/fpr_size optimization to recognizeifn_va_arg.


Thanks,
- Tom

References:
- Re: pass_stdarg problem when run after pass_lim
  - From: Tom de Vries
- Re: pass_stdarg problem when run after pass_lim
  - From: Michael Matz
- Re: pass_stdarg problem when run after pass_lim
  - From: Tom de Vries
- Re: pass_stdarg problem when run after pass_lim
  - From: Michael Matz
- Postpone expanding va_arg until pass_stdarg
  - From: Tom de Vries
- Re: Postpone expanding va_arg until pass_stdarg
  - From: Richard Biener
- Re: Postpone expanding va_arg until pass_stdarg
  - From: Tom de Vries
- Re: Postpone expanding va_arg until pass_stdarg
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]