This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

libgcc/ pattern question


I tracked down a bug in building v850-rtems to a place in libgcc/
where the code setting tmake_file did not append, it overwrote the previous
value. This caused v850-rtems to throw away the previous setting which
adding the newlib/sys/rtems/* directories to the include path.

diff --git a/libgcc/ b/libgcc/
index bdc725f..f8f74cc 100644
--- a/libgcc/
+++ b/libgcc/
@@ -1195,7 +1195,7 @@ tilepro*-*-linux*)
-       tmake_file="v850/t-v850 t-fdpbit"
+       tmake_file="${tmake_file} v850/t-v850 t-fdpbit"
        tmake_file="$tmake_file vax/t-linux"

I see other places in this case statement where tmake_file is reset. Is
this OK?
Should be be added to all the time when the pattern is CPU*-*-*? all the

On a style inconsistency note, I see that some stanzas use $tmake_file
most use ${tmake_file}. Is there a rule? Personally I like having {} and
appear to have it.

Feedback appreciated.

Joel Sherrill, Ph.D.             Director of Research & Development        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]