Re: Running contrib/config-list.mk from the buildbots

[Jan-Benedict Glaw <jbglaw at lug-owl dot de>]

On Tue, 2013-11-19 12:08:05 -0500, Diego Novillo <dnovillo@google.com> wrote:
[conffig-list.mk]
> Really, the only thing interesting about the script is the broad set
> of targets it uses. If you just added them to the schedule of builds,
> that should be sufficient. We could even decide not to add all of
> them. And certainly take out the ones that just don't build as-is.

With -Werror in place, I think not a single target will build right now, due to
warnings/errors in common code. Just picking a recent s390x-linux as an
example:

buildrobot@toolchaintest-host:~/xx$ wget -O s390x-linux.buildlog --quiet 'http://toolchain.lug-owl.de/buildbot/deliver_artifact.php?mode=download&id=252870'
buildrobot@toolchaintest-host:~/xx$ grep 'warning: ' s390x-linux.buildlog |wc -l
116
buildrobot@toolchaintest-host:~/xx$ grep 'warning: ' s390x-linux.buildlog |cut -f 4- -d ':'|sort|uniq -c
      3  operand 2 missing mode?
      1  remember to run `libtool --finish /home/jbglaw/build/s390x-linux/_install_/libexec/gcc/s390x-linux/4.9.0'
      7  source missing a mode?
      4  warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     11  warning: format '%d' expects argument of type 'int', but argument 4 has type 'const char*' [-Wformat=]
      8  warning: format '%d' expects argument of type 'int', but argument 5 has type 'const char*' [-Wformat=]
      2  warning: format '%s' expects argument of type 'char*', but argument 5 has type 'int' [-Wformat=]
      3  warning: format '%s' expects argument of type 'char*', but argument 6 has type 'int' [-Wformat=]
     18  warning: missing sentinel in function call [-Wformat=]
     20  warning: too many arguments for format [-Wformat-extra-args]
     19  warning: unknown conversion type character 'r' in format [-Wformat=]
     19  warning: unknown conversion type character 'R' in format [-Wformat=]
      1  warning: unknown conversion type character 'X' in format [-Wformat=]

Some of those are probably spurious and won't break the build, but all
of the -Wformat diagnostics will:

buildrobot@toolchaintest-host:~/xx$ grep "too many arguments for format" s390x-linux.buildlog |cut -f 1 -d ':'|sort|uniq -c
      8 /home/jbglaw/repos/gcc/gcc/cp/error.c
      1 /home/jbglaw/repos/gcc/gcc/cp/method.c
      3 /home/jbglaw/repos/gcc/gcc/diagnostic.c
      2 /home/jbglaw/repos/gcc/gcc/langhooks.c
      6 /home/jbglaw/repos/gcc/gcc/tree.c

I don't understand the "missing sentinel" messages; they're on code like this:

g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -DGENERATOR_FILE -I. -Ibuild -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/build -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/opt/cfarm/gmp-latest/include -I/opt/cfarm/mpfr-latest/include -I/opt/cfarm/mpc-latest/include  -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace    \
-o build/read-md.o /home/jbglaw/repos/gcc/gcc/read-md.c
/home/jbglaw/repos/gcc/gcc/read-md.c: In function 'const char* join_c_conditions(const char*, const char*)':
/home/jbglaw/repos/gcc/gcc/read-md.c:203:58: warning: missing sentinel in function call [-Wformat=]
   result = concat ("(", cond1, ") && (", cond2, ")", NULL);
                                                          ^

Maybe "NULL" isn't of pointer type and thus it would need a cast here...

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
  Signature of:                        Lauf nicht vor Deinem GlÃck davon:
  the second  :                             Es kÃnnte hinter Dir stehen!

Attachment: signature.asc
Description: Digital signature