This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] RE: libcilkrts breaks non-bootstrap build
- From: Tom de Vries <Tom_deVries at mentor dot com>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- Cc: "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Tue, 5 Nov 2013 10:12:10 +0100
- Subject: Re: [PATCH] RE: libcilkrts breaks non-bootstrap build
- Authentication-results: sourceware.org; auth=none
- References: <BF230D13CA30DD48930C31D4099330003A49AE3D at FMSMSX101 dot amr dot corp dot intel dot com>
On 05/11/13 05:17, Iyer, Balaji V wrote:
> Is the following patch OK to fix this issue?
>
Balaji,
the patch fixes the problem for me, thanks.
I can't approve your patch, but it looks good to me.
FWIW, I stumbled upon this text at http://gcc.gnu.org/codingconventions.html
which is related to this patch, and also to the top-level part of your commit
r204173, which is missing at 'src':
...
Top-level configure.ac, configure, Makefile.in, config-ml.in, config.if and most
other top-level shell-scripts: Please try to keep these files in sync with the
corresponding files in the src repository at sourceware.org. Some people hope to
eventually merge these trees into a single repository; keeping them in sync
helps this goal. When you check in a patch to one of these files, please check
it in the src tree too, or ask someone else with write access there to do so.
...
Thanks,
- Tom
> Thanks,
>
> Balaji V. Iyer.
>
> Index: configure.ac
> ===================================================================
> --- configure.ac (revision 204381)
> +++ configure.ac (working copy)
> @@ -2061,7 +2061,7 @@
> case ,${enable_languages}, in
> *,c++,*) ;;
> *)
> - noconfigdirs="$noconfigdirs target-libitm target-libsanitizer target-libvtv"
> + noconfigdirs="$noconfigdirs target-libcilkrts target-libitm target-libsanitizer target-libvtv"
> ;;
> esac
>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 204381)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,9 @@
> +2013-11-04 Balaji V. Iyer <balaji.v.iyer@intel.com>
> +
> + * configure.ac: Added libcilkrts to noconfig list when C++ is not
> + supported.
> + * configure: Regenerated.
> +
> 2013-11-01 Trevor Saunders <tsaunders@mozilla.com>
>
> * MAINTAINERS (Write After Approval): Add myself.
> Index: configure
> ===================================================================
> --- configure (revision 204381)
> +++ configure (working copy)
> @@ -6630,7 +6630,7 @@
> case ,${enable_languages}, in
> *,c++,*) ;;
> *)
> - noconfigdirs="$noconfigdirs target-libitm target-libsanitizer target-libvtv"
> + noconfigdirs="$noconfigdirs target-libcilkrts target-libitm target-libsanitizer target-libvtv"
> ;;
> esac