This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] RE: libcilkrts/runtime/config/generic/cilk-abi-vla.c failure
- From: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, Jakub Jelinek <jakub at redhat dot com>
- Cc: Gerald Pfeifer <gerald at pfeifer dot com>, Jeff Law <law at redhat dot com>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Thu, 31 Oct 2013 20:43:40 +0000
- Subject: RE: [PATCH] RE: libcilkrts/runtime/config/generic/cilk-abi-vla.c failure
- Authentication-results: sourceware.org; auth=none
- References: <BF230D13CA30DD48930C31D4099330003A495A50 at FMSMSX101 dot amr dot corp dot intel dot com> <20131031074533 dot GM27813 at tucnak dot zalov dot cz> <BF230D13CA30DD48930C31D4099330003A4963EA at FMSMSX101 dot amr dot corp dot intel dot com> <20131031135031 dot GQ27813 at tucnak dot zalov dot cz> <ydd1u31o7y3 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>
Hi Rainer,
This patch looks OK.
Thanks,
Balaji V. Iyer.
-----Original Message-----
From: gcc-owner@gcc.gnu.org [mailto:gcc-owner@gcc.gnu.org] On Behalf Of Rainer Orth
Sent: Thursday, October 31, 2013 10:02 AM
To: Jakub Jelinek
Cc: Iyer, Balaji V; Gerald Pfeifer; Jeff Law; gcc@gcc.gnu.org
Subject: Re: [PATCH] RE: libcilkrts/runtime/config/generic/cilk-abi-vla.c failure
Jakub Jelinek <jakub@redhat.com> writes:
> On Thu, Oct 31, 2013 at 01:32:19PM +0000, Iyer, Balaji V wrote:
>> > It is not just about not including 3, but also the []s in
>> > configure.ac were eaten by m4. In any case, shouldn't you fix also
>> > config/generic?
>> >
>>
>> I am in the process of fixing config/generic. I also replaced [456]
>> with i?86. That should work fine right?
>
> Yes.
Even with that change, i386-pc-solaris2.11 bootstrap is broken in libcilkrts in two different ways:
* Configuring the library fails for the 64-bit multilib: config.log
shows
configure:3105: checking whether the C++ compiler works
configure:3114: ./a.out
ld.so.1: a.out: fatal: /var/gcc/regression/trunk/11-gcc/build/./gcc/libgcc_s.so.1: wrong ELF class: ELFCLASS32
/vol/gcc/src/hg/trunk/local/libcilkrts/configure[3116]: eval: line 1: 4955: Killed
configure:3118: $? = 265
configure:3125: error: in `/var/gcc/regression/trunk/11-gcc/build/i386-pc-solaris2.11/amd64/libcilkrts':
configure:3127: error: cannot run C++ compiled programs.
There's no 64-bit libgcc_s.so.1 installed in the runtime linker's
default search path, and toplevel Makefile (via RPATH_ENVVAR) only
takes care of the default multilib. This is also reported for the
libgcj case in PR other/43445.
* Even after setting LD_LIBRARY_PATH_64 to work around this,
compilation fails for os-unix.c:
/vol/gcc/src/hg/trunk/local/libcilkrts/runtime/os-unix.c:66:5: error: #error "Unsupported OS"
# error "Unsupported OS"
^
/vol/gcc/src/hg/trunk/local/libcilkrts/runtime/os-unix.c: In function '__cilkrts_hardware_cpu_count':
/vol/gcc/src/hg/trunk/local/libcilkrts/runtime/os-unix.c:378:2: error: #error "Unknown architecture"
#error "Unknown architecture"
^
/vol/gcc/src/hg/trunk/local/libcilkrts/runtime/os-unix.c: In function '__cilkrts_yield':
/vol/gcc/src/hg/trunk/local/libcilkrts/runtime/os-unix.c:411:5: warning: implicit declaration of function 'pthread_yield' [-Wimplicit-function-declaration]
pthread_yield();
^
make[2]: *** [os-unix.lo] Error 1
The following patch fixes this:
2013-10-31 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* runtime/os-unix.c [__sun__ && __svr4__]: Include <sched.h>.
(__cilkrts_hardware_cpu_count) [__sun__ && __svr4__]: Use sysconf.
(__cilkrts_yield) [__sun__ && __svr4__]: Use sched_yield.