This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
RE: Cilk Library
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- Cc: Jeff Law <law at redhat dot com>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>, "Aldy Hernandez (aldyh at redhat dot com)" <aldyh at redhat dot com>, "rth at redhat dot com" <rth at redhat dot com>, "Jason Merrill (jason at redhat dot com)" <jason at redhat dot com>
- Date: Wed, 23 Oct 2013 20:22:25 +0000
- Subject: RE: Cilk Library
- Authentication-results: sourceware.org; auth=none
- References: <BF230D13CA30DD48930C31D4099330003A47B9F3 at FMSMSX101 dot amr dot corp dot intel dot com> <525460A9 dot 2040409 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A48660C at FMSMSX101 dot amr dot corp dot intel dot com> <525DA223 dot 3010607 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A488B2C at FMSMSX101 dot amr dot corp dot intel dot com> <52675B4D dot 20905 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A492B97 at FMSMSX101 dot amr dot corp dot intel dot com>
On Wed, 23 Oct 2013, Iyer, Balaji V wrote:
> Hi Jeff et al.,
> Here is a link to the updated patch
> (https://docs.google.com/file/d/0BzEpbbnrYKsSbVY2X3ZLUnd4OXM/edit?usp=sharing).
> We have fixed all the issues that Joseph pointed out in
> http://gcc.gnu.org/ml/gcc/2013-10/msg00090.html. We have also added
> symbol versioning and have double-checked (using nm) that all symbols
> are hidden unless we have explicitly allowed them to be public.
As I said in my previous comments, please follow libatomic, libitm,
libsanitizer or libvtv in using a configure.tgt file in the library's
subdirectory to describe what systems are supported. This is especially
important now that all toplevel patches need applying to three rather than
two repositories (GCC SVN, src CVS, binutils-gdb git) - anything logically
specific to one of those three should go in an appropriate subdirectory
whenever possible, to reduce the number of changes needing syncing to
multiple places.
(Yes, there's lots of configuration specific to newlib/libgloss, binutils,
gdb or individual GCC libraries that's still hardcoded in the toplevel
configure.ac and should move to such configure.tgt or similar files in
subdirectories. Patches moving it to such files are certainly welcome.
But at least we shouldn't add new directories with details at toplevel of
what targets they support.)
--
Joseph S. Myers
joseph@codesourcery.com