This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: To Steering Committee: RFC for patch revert policy (PR48403, bootstrap broken on many targets)
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: Jeff Law <law at redhat dot com>, gcc at gcc dot gnu dot org, Bernd Schmidt <bernds at codesourcery dot com>, Ian Lance Taylor <iant at google dot com>, Steven Bosscher <stevenb dot gcc at gmail dot com>, David Edelsohn <dje at gcc dot gnu dot org>, Benjamin Kosnik <bkoz at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Tue, 5 Apr 2011 12:37:28 +0200
- Subject: Re: To Steering Committee: RFC for patch revert policy (PR48403, bootstrap broken on many targets)
- References: <BANLkTi=AgWe2QOQ=bZ+a1XT7YQ1J1YKtyw@mail.gmail.com> <4D9A6CDA.6080203@codesourcery.com> <4D9A7EAD.7010101@redhat.com> <201104051050.57716.ebotcazou@adacore.com>
On Tue, Apr 5, 2011 at 10:50 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> I definitely think that if there is a policy change that an allowance be
>> made for weekends/holidays and that if a patch has been identified and
>> the offender has acknowledged the issue and is actively working on the
>> problem give the offender time to resolve the issue.
>
> This weekends/holidays allowance would be dangerous and counter-productive:
> people would rush to install risky changes on Friday and leave for the
> week-end fingers crossed. ?This would be worse than the current policy IMO.
Indeed. I usually try to avoid committing such patches on Fridays. It's not
an inconvenience to delay committing to Monday if you don't work on weekends
anyway, is it?
So, I simply expect people to apply common sense when they commit
(large) patches. If you are not available to fix possible fallout on the
next day(s), don't commit. Similar, don't commit such things 5 minutes
before you leave office. The next morning will also do.
Richard.
> --
> Eric Botcazou
>