This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Gengtype : strange code in output_type_enum

From: Arnaud Charlet <charlet at adacore dot com>
To: jeremie dot salvucci at free dot fr
Cc: gcc <gcc at gcc dot gnu dot org>, laurynas <laurynas dot biveinis at gmail dot com>, basile <basile at starynkevitch dot net>
Date: Fri, 27 Aug 2010 16:23:04 +0200
Subject: Re: Gengtype : strange code in output_type_enum
References: <1117289297.446531282913343686.JavaMail.root@zimbra30-e5.priv.proxad.net> <662566448.453381282918810720.JavaMail.root@zimbra30-e5.priv.proxad.net>

> In function output_type_enum of gcc/gengtype.c, we replaced 
> 
> -  if (s->kind == TYPE_PARAM_STRUCT && s->u.s.line.file != NULL)
> +  if (s->kind == TYPE_PARAM_STRUCT && s->u.param_struct.line.file !=
> NULL)
> 
> And Gengtype works like before with c,c++, lto enabled.
> 
> Do you think we have to submit a one line patch (if yes, could it be reviewed

Sure, one line patches are actually welcome since they are well isolated and
easy to review, as opposed to large big patches containing unrelated stuff
which have basically zero chance to get accepted/reviewed (other than
"please break you patch into multiple pieces).

Arno

References:
- Re: Gengtype : strange code in output_type_enum
  - From: jeremie . salvucci
- Re: Gengtype : strange code in output_type_enum
  - From: jeremie . salvucci

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]