This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Improving gengtype (for plugin support notably) - how to get a rather big patch accepted?


On Thu, 2010-08-26 at 10:41 -0700, Ian Lance Taylor wrote:
> Basile Starynkevitch <basile@starynkevitch.net> writes:
> 
> > On Thu, 2010-08-26 at 12:23 +0200, Paolo Bonzini wrote:
> >> On 08/24/2010 07:38 PM, Basile Starynkevitch wrote:
> >> > (actually, this happened to us before e.g.
> >> > http://gcc.gnu.org/ml/gcc-patches/2010-06/msg02178.html  etc).
> >> 
> >> Sorry, but that's what happens when you ignore the maintainers' opinion.
> >> 
> >> Do not misunderstand me: I'm very interested in your works and happy to 
> >> review your patches.  However, if you are told to do A and do B, 
> >> maintainers will only remind you once that you should have done A.
> >
> > Could you instantiate A & B please?
> 
> I think that A is Paolo's suggestion here:
> 
> http://gcc.gnu.org/ml/gcc-patches/2010-06/msg01987.html
> 
> B is here:
> 
> http://gcc.gnu.org/ml/gcc-patches/2010-06/msg02178.html
> 
> Ian

Thanks for spotting that out. Our current patch (we actually had a
working version, but we are now cleaning it up and preparing the patch)
has a build/version.o linked into gengtype.

I believe we should be able to send a two-piece patch.

And by the way, outside of the persistency mechanism (which is quite a
large file, gengtype-state.c, trivially made of read_state_* & matching
write_state_* routines) there are no algorithmic changes in our patch. 
I believe that the generated files are the same as before. The patch
might be not trivially small, but the changes are routine. As an
example, adding an input_file structure requires changing many functions
formals refering to some input file from const char* to input_file*.
This is not a big deal, but it makes the patch a bit big.


BTW, this is not the first time that either Jeremie or me are hut by a
strange [probably makefile or autoconf related, certainly unrelated to
our gengtype work] bug; in some occasions, we have to make a distclean
to make GCC work. This happenned to me several times in the past.

And Jeremie will soon [in a week or two] become a full time student
again, so he won't have much time to spend on GCC. In my perception, he
is very clever, and should concentrate his efforts on studying, not on
GCC hacking.


Cheers.
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]