This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Improving gengtype (for plugin support notably) - how to get a rather big patch accepted?
- From: Laurynas Biveinis <laurynas dot biveinis at gmail dot com>
- To: basile at starynkevitch dot net
- Cc: gcc at gcc dot gnu dot org, jeremie dot salvucci at free dot fr
- Date: Wed, 25 Aug 2010 09:11:58 +0300
- Subject: Re: Improving gengtype (for plugin support notably) - how to get a rather big patch accepted?
- References: <1282671483.2414.61.camel@glinka>
2010/8/24 Basile Starynkevitch <basile@starynkevitch.net>:
> Hello All
>
> Jeremie Salvucci and me Basile are working on improving gengtype. Our
> patch is still buggy [curious people might retrieve it from
> http://starynkevitch.net/Basile/gengtype-r163335-24august-2010.diff
I was meaning to take a look to get an idea what the patch is doing,
but it arbitrarily changes indentation in otherwise-untouched places.
Not that it matters now, as you are not submitting it, but I believe
it is easier to always work within code formatting rules than to
properly format only before submission.
Other than that, I can only agree with what Ian advised for you.
--
Laurynas