This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Why not contribute? (to GCC)

> So we need more patch reviewers.  How can that be addressed?

The situation has improved in this area since the "Reviewer" position was 
introduced a few years ago though.

> It is also important to make more effective use of the patch
> reviewers we already have.  What could be done to make the
> patch review process easier or less time-consuming?

Write small patches.  Even if you know that the change is not a complete 
solution to the problem, it might be good enough as a first try so adding 
a ??? comment would be sufficient.

Eliminate the easy mistakes in patches.  GCC uses strict coding conventions, 
including formatting and commenting conventions, so not following them is a 
mistake that will be flagged as such.  Fortunately this is easy to correct, 
you don't even need to read the (whole) documentation, just look around in 
the existing code you're modifying and make it so that the new code cannot 
be distinguished from the old one in this respect.

Write proper ChangeLogs.  They are kind of executive summaries for patches and 
help to grasp what they do.  The various ChangeLog files have many examples.

Eric Botcazou

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]