This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Outdated comment in real.c (was: constant folding)
- From: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- To: Vincent Lefevre <vincent+gcc at vinc17 dot org>
- Cc: gcc at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 28 Sep 2009 12:24:20 -0400 (EDT)
- Subject: Re: Outdated comment in real.c (was: constant folding)
- References: <E1Mqqop-0005k2-HH@quiche.loria.fr> <A02DAD6933AA490593D28C614961E00A@glap> <20090925001855.GU657@prunille.vinc17.org> <20090925002813.GB582@prunille.vinc17.org>
On Fri, 25 Sep 2009, Vincent Lefevre wrote:
> [Cc to the gcc mailing-list]
>
> On 2009-09-25 02:18:55 +0200, Vincent Lefevre wrote:
> > Also, as EXP_BITS is the full (biased) exponent size, it seems that
> > the real.c comment is buggy (27 -> 26).
>
> Looking at the history:
>
> -#define EXP_BITS (32 - 5)
> +#define EXP_BITS (32 - 6)
The following change fixes the comment. Tested with "make" on
x86_64-unknown-linux-gnu. I'll install this as "obvious" tomorrow if
nobody comments on the patch.
--Kaveh
2009-09-28 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* real.c: Fix comment to reflect actual exponent size.
diff -rup orig/egcc-SVN20090928/gcc/real.c egcc-SVN20090928/gcc/real.c
--- orig/egcc-SVN20090928/gcc/real.c 2009-09-18 02:00:54.000000000 +0200
+++ egcc-SVN20090928/gcc/real.c 2009-09-28 18:06:06.000000000 +0200
@@ -57,7 +57,7 @@
Both of these requirements are easily satisfied. The largest target
significand is 113 bits; we store at least 160. The smallest
- denormal number fits in 17 exponent bits; we store 27.
+ denormal number fits in 17 exponent bits; we store 26.
Note that the decimal string conversion routines are sensitive to
rounding errors. Since the raw arithmetic routines do not themselves