This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MSVC hook function prologue


2009/9/3 Paolo Bonzini <bonzini@gnu.org>:
> ? if (TARGET_64BIT
> ? ? ? ? !is_attribute_p ("msvc_prologue", name))
> ? ? ? : is_attribute_p ("msvc_prologue", name))
> ? ? {
> ? ? ? warning (OPT_Wattributes, "%qE attribute not available for "
> ? ? ? ? ? ? ? ?"%d-bit", name, TARGET_64BIT ? 64 : 32);
> ? ? ? *no_add_attrs = true;
> ? ? ? return NULL_TREE;
> ? ?}

Shouldn't it be this instead?

  if (is_attribute_p ("msvc_prologue", name))
    {
      warning (OPT_Wattributes, "%qE attribute not available for "
               "%d-bit", name, TARGET_64BIT ? 64 : 32);
      *no_add_attrs = true;
      return NULL_TREE;
   }

as otherwise for 64-bit target warning would be shown always?

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]