This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: r150960 changed ltmain.sh and broke the build

From: Paolo Bonzini <bonzini at gnu dot org>
To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
Cc: NightStrike <nightstrike at gmail dot com>, gcc at gcc dot gnu dot org, davek at gcc dot gnu dot org, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Mook - <mook dot gcc at gmail dot com>, Kai Tietz <ktietz70 at googlemail dot com>
Date: Wed, 26 Aug 2009 12:47:17 +0200
Subject: Re: r150960 changed ltmain.sh and broke the build
References: <b609cb3b0908260211q4ca347efw94f4e420d1ac5efc@mail.gmail.com> <4A950CFE.7060709@gmail.com> <4A950C2A.8040204@gnu.org> <4A9510BA.1030704@gmail.com> <4A9512E2.9010104@gmail.com>

On 08/26/2009 12:48 PM, Dave Korn wrote:

Dave Korn wrote:

Also please single-quote the commands.
Ok, why?


   BTW should I do that for all four of the patterns?  And what about $dirname
and $basename, and the couple of dozen other locations in ltmain.sh that use
quoted sed scripts?  (You didn't answer my question about "why" yet so I can't
infer anything.)

I don't like very much backslash sequences in double-quoted variables. It's portable, but somewhat unintuitive. But this is upstream code after all, so it's better to leave it alone. Sorry for the false alarm.

Paolo

Follow-Ups:
- Re: r150960 changed ltmain.sh and broke the build
  - From: Dave Korn

References:
- r150960 changed ltmain.sh and broke the build
  - From: NightStrike
- Re: r150960 changed ltmain.sh and broke the build
  - From: Dave Korn
- Re: r150960 changed ltmain.sh and broke the build
  - From: Paolo Bonzini
- Re: r150960 changed ltmain.sh and broke the build
  - From: Dave Korn
- Re: r150960 changed ltmain.sh and broke the build
  - From: Dave Korn

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]