This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] Thoughts on reordering the source tree
On Fri, May 1, 2009 at 3:54 PM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> attribs.c:#include "c-common.h"
> cgraphunit.c:#include "c-common.h"
> ipa-pure-const.c:#include "c-common.h"
> ipa-reference.c:#include "c-common.h"
> ipa-struct-reorg.c:#include "c-tree.h"
> ipa-struct-reorg.c:#include "c-common.h"
> ipa-type-escape.c:#include "c-common.h"
> ipa-utils.c:#include "c-common.h"
> matrix-reorg.c:#include "c-tree.h"
> matrix-reorg.c:#include "c-common.h"
> stub-objc.c:#include "c-common.h"
> tree-if-conv.c:#include "c-common.h"
> tree-nomudflap.c:#include "c-tree.h"
> tree-nomudflap.c:#include "c-common.h"
> tree-ssa-structalias.c:#include "c-common.h"
> tree-ssa-structalias.c:#include "c-tree.h"
> varasm.c:#include "c-pragma.h"
These are now fixed (I'm testing a patch for varasm.c and attribs.c).
> config/h8300/h8300.c:#include "c-pragma.h"
> config/i386/i386.c:#include "c-common.h"
> config/sh/sh.c:#include "c-pragma.h"
> config/spu/spu.c:#include "c-common.h"
These I will need to check via a cross compiler. Andrew P., maybe you
can look at SPU?
> And these are the problem inclusions of files specific to C and ObjC from
> files also shared with C++:
>
> c-common.c:#include "c-tree.h"
> c-dump.c:#include "c-tree.h"
> c-gimplify.c:#include "c-tree.h"
> c-lex.c:#include "c-tree.h"
> c-opts.c:#include "c-tree.h" ? ? ? ? ? ?/* For c_cpp_error. ?*/
> c-pretty-print.c:#include "c-tree.h"
Can you explain a bit more about this is problem? Do you already have
some idea what needs to be done?
As an example, I was looking at c_build_qualified_type(). It is
prototyped in c-tree.h, defined in c-typeck.c, and used in c-common.c.
How should such cases be fixed?
Ciao!
Steven