This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros
- From: Matthew Wilcox <matthew at wil dot cx>
- To: Joe Perches <joe at perches dot com>
- Cc: LKML <linux-kernel at vger dot kernel dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, linux-fsdevel at vger dot kernel dot org, gcc at gcc dot gnu dot org
- Date: Tue, 26 Feb 2008 21:13:16 -0700
- Subject: Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros
- References: <1204081722.19319.405.camel@localhost> <1204084947.19319.411.camel@localhost>
On Tue, Feb 26, 2008 at 08:02:27PM -0800, Joe Perches wrote:
> Converting inline __attribute__((format (printf,x,y) functions
> to macros or statement expressions produces smaller objects
>
> before:
> $ size vmlinux
> text data bss dec hex filename
> 4716770 474560 618496 5809826 58a6a2 vmlinux
> after:
> $ size vmlinux
> text data bss dec hex filename
> 4716706 474560 618496 5809762 58a662 vmlinux
> -static inline void __attribute__((format(printf, 1, 2)))
> -__simple_attr_check_format(const char *fmt, ...)
> -{
> - /* don't do anything, just let the compiler check the arguments; */
> -}
> +/* don't do anything, just let the compiler check the arguments; */
> +
> +#define __simple_attr_check_format(fmt, args...) \
> + do { if (0) printk(fmt, ##args); } while (0)
That's very interesting. It's only 64 bytes, but still, it's not
supposed to have any different effect. Could you distill a test case
for the GCC folks and file it in their bugzilla?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."