This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Problem with ARM_DOUBLEWORD_ALIGN on ARM
- From: Geert Bosch <bosch at gnat dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Paul Brook <paul at codesourcery dot com>, drow at false dot org, gcc at gcc dot gnu dot org
- Date: Wed, 26 Dec 2007 15:05:37 -0500
- Subject: Re: Problem with ARM_DOUBLEWORD_ALIGN on ARM
- References: <20071121233222.B5EF748CC02@nile.gnat.com> <4772AA79.1060603@codesourcery.com>
On Dec 26, 2007, at 14:24, Mark Mitchell wrote:
Geert Bosch wrote:
Nested functions aren't used that much in C indeed... :)
Paul, would you please review this patch?
This patch isn't good. While it addressed the alignment
issue, it didn't correctly adjust all necessary offset
computations.
One of the problems is that this port has grown many
magic adjustments and mostly similar recalculations.
Olivier Hainque has refactored some of the code and
has a proper patch that has had a good amount of testing
now. We also have a testcase in C.
We'll submit this for review soon. In the meantime,
please consider this patch withdrawm.
-Geert