This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: I don't understand some of gcc-4.1-20070514, a patch here.
- From: Eric Botcazou <ebotcazou at libertysurf dot fr>
- To: "J.C. Pizarro" <jcpiza at gmail dot com>
- Cc: gcc at gcc dot gnu dot org
- Date: Sat, 19 May 2007 14:34:15 +0200
- Subject: Re: I don't understand some of gcc-4.1-20070514, a patch here.
- References: <998d0e4a0705190357r1ae80d7drdb47103eb1c88c51@mail.gmail.com>
> you have this nice cleanup's patch of gcc/loop.c that transliterates the
> logic of the uses of the loop_invariant_p (..) and consec_sets_invariant_p
> (..) functions.
First of all, patches should be posted to gcc-patches@, not to this list.
> I've patched it, builded and executed, and again again with this patched
> gcc. It's OK.
This is not sufficient. Patch submission must comply with strict rules that
are listed at http://gcc.gnu.org/contribute.html.
> To the expert person only, please, read now the loop algorithms that
> uses *_OF_LOOP_P if there is any failed logic or not.
loop.c is gone in the mainline sources. Patching it on the 4.1 branch is
allowed only if you have a testcase that exposes a serious bug.
--
Eric Botcazou